Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize alert behavior with no data #43

Merged
merged 1 commit into from
Jun 25, 2015
Merged

Add ability to customize alert behavior with no data #43

merged 1 commit into from
Jun 25, 2015

Conversation

scottnonnenberg
Copy link
Contributor

New 'no_data' config value can now be set to 'normal', 'warning' or 'critical' at the top-level, or per alert. Default retains the same behavior as today: 'critical' alerts. Includes associated readme updates.

Background

I'm using statsd to keep track of a few metrics like 'crashes', 'deploys' and 'launches.' Whenever these are non-zero, I want a notification. As you might expect, I only send data from my scripts and apps when it's non-zero. Statsd takes care of this for me, by remembering the data point after I initially send it, sending zeros thereafter (this is configurable, of course).

When I need to restart statsd or the entire machine, those data points are no longer known to statsd. Today I get critical alerts whenever this happens. This allows that logging level for 'no data' to be configured both globally and per-alert.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 65.4% when pulling 9d5ce4e on scottnonnenberg:allow-none into c07ab8b on klen:develop.

@ghost
Copy link

ghost commented Jun 8, 2015

Very handy as we put instances down as part of scaling process.

klen added a commit that referenced this pull request Jun 25, 2015
Add ability to customize alert behavior with no data
@klen klen merged commit 70ee783 into klen:develop Jun 25, 2015
@klen
Copy link
Owner

klen commented Jun 25, 2015

Thank you for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants