This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Enable/disable console output #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ionochkin
changed the title
sinan
added a commit
that referenced
this pull request
Feb 26, 2016
…nsole-output Enable/disable console output
This was referenced Feb 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sinan, can you please review this fix?
The reason why I made these changes is that
kdkeeps references toconsolemethods and use those references forkd.log,kd.warn,kd.erroretc. This logic makes useless any try to overwriteconsolemethods to disable logging - https://github.com/koding/koding/blob/master/client/app/lib/util/disableLogs.coffee#L34Wrapping
consolecalls with functions helps to solve this problem