Skip to content
This repository was archived by the owner on Nov 25, 2020. It is now read-only.

allow entry point from any dom element #170

Merged
merged 3 commits into from
Dec 27, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/components/loader/loaderview.coffee
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'canvas-loader'
require 'kd-shim-canvas-loader'
KDView = require '../../core/view'

module.exports = class KDLoaderView extends KDView
Expand Down
10 changes: 6 additions & 4 deletions lib/core/view.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ debug = require('debug') 'kd:view'
$ = require 'jquery'
KD = require './kd'
KDObject = require './object'
MutationSummary = require 'mutation-summary'
MutationSummary = require 'kd-shim-mutation-summary'

module.exports = class KDView extends KDObject

Expand Down Expand Up @@ -59,12 +59,14 @@ module.exports = class KDView extends KDObject
objects.overrider[title] = item
objects.overrider

appendToDomBody: ->
appendToParentElement: (parent) ->
@parentIsInDom = yes
unless @lazy
$("body").append @$()
$(parent).append @$()
@utils.defer => @emit "viewAppended"

appendToDomBody: -> @appendToParentElement document.body

# #
# INSTANCE LEVEL
# #
Expand Down Expand Up @@ -919,4 +921,4 @@ module.exports = class KDView extends KDObject
windowController = KD.getSingleton 'windowController'
windowController.setKeyView null

activateKeyView: -> @emit? 'KDViewBecameKeyView'
activateKeyView: -> @emit? 'KDViewBecameKeyView'
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "kd.js",
"version": "1.1.27",
"version": "1.1.28",
"description": "a collection of ui widgets and other nice things",
"main": "build/lib/index.js",
"scripts": {
Expand Down Expand Up @@ -57,9 +57,5 @@
"stylus": "^0.54.5",
"uglify-js": "^2.7.3",
"watchify": "^3.7.0"
},
"browser": {
"canvas-loader": "kd-shim-canvas-loader",
"mutation-summary": "kd-shim-mutation-summary"
}
}