This repository was archived by the owner on Nov 25, 2020. It is now read-only.
addItem Refactor #37
Merged
addItem Refactor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is boxed or not and with lastToFirst option.
| @itemsOrdered = [] unless @itemsOrdered | ||
| # CtF: this must be fixed: duplicate itemsOrdered and KDListView.items | ||
| # Object.defineProperty this, "itemsOrdered", get : => @getListView().items | ||
| Object.defineProperty this, "itemsOrdered", get : => @getListView().items |
There was a problem hiding this comment.
put a deprecation warning here, so that devs can remove the itemsOrdered use from their implementations, which would read: KDListViewController::itemsOrdered is deprecated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDListViewController@itemOrderedto be a reflection of itslistView's items.KDListView's item addition.boxedand!boxed.lastToFirstand!lastToFirst