This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Test stubs for Core modules #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,9 @@ | |||
|
|
|||
| module.exports = class KDEventEmitter | |||
|
|
|||
| # FIXME (sb) - this class has no knowledge of @Wildcard (and requiring it | |||
| # would make a circular dependency). Also, this doesn't appear to be used | |||
| # anywhere in the framework. | |||
There was a problem hiding this comment.
@humanchimp any note here for an improvement?
szkl
pushed a commit
that referenced
this pull request
May 10, 2014
sinan
pushed a commit
to sinan/kd
that referenced
this pull request
Feb 27, 2015
…-on-esc dialog: close dialog on ESC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Where should the reviewer start?
Look at the test files in
src/core/testHow should this be manually tested?
Run
gulpand then go to http://localhost:8080/test/index.html to run the test suite