This repository was archived by the owner on Nov 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Removelistitemfix #46
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1cec1f5
ListViewController: Add default value for lastToFirst
canthefason 144fc5f
ListViewController: Fix item view wwas not destroyed after remove bug
canthefason e7a6c44
ListView: Set default LastToFirst option to no
canthefason b74b215
ListView: Fix removeItem index parameter
canthefason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ module.exports = class KDListViewController extends KDViewController | |
# rename these options | ||
options.noItemFoundWidget or= null | ||
options.noMoreItemFoundWidget or= null | ||
options.lastToFirst ?= no | ||
|
||
Object.defineProperty this, "itemsOrdered", get : => | ||
warn "KDListViewController::itemsOrdered is deprecated." | ||
|
@@ -155,7 +156,6 @@ module.exports = class KDListViewController extends KDViewController | |
|
||
|
||
removeItem: (itemInstance, itemData, index) -> | ||
|
||
return unless itemInstance or itemData or index? | ||
|
||
@getListView().removeItem itemInstance, itemData, index | ||
|
@@ -180,6 +180,7 @@ module.exports = class KDListViewController extends KDViewController | |
|
||
@emit 'UnregisteringItem', itemInstance, index | ||
actualIndex = if @getOptions().lastToFirst then @getItemCount() - index - 1 else index | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. set default lastToFirst value, which needs an updated actualIndex assignment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this needs |
||
|
||
@getListItems().splice actualIndex, 1 | ||
if itemInstance.getData()? | ||
delete @itemsIndexed[itemInstance.getItemDataId()] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be the race condition we were seing maybe?
index
in params listi
in function block.