This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Prevent gulp from stopping because of errors #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinan
added a commit
that referenced
this pull request
Mar 19, 2014
Prevent gulp from stopping because of errors
sinan
pushed a commit
to sinan/kd
that referenced
this pull request
Mar 10, 2015
windowController: window focus/blur handling improved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds an uncaughtException handler to gulp that prevents the process from exiting due to compile errors.
Where should the reviewer start?
gulpfile.coffeeHow should it be manually tested?
Start the watch task with
gulp, add some broken CoffeeScript to one of the watched files, watch the build process keep on going.Any background context you want to provide?
Having to restart the gulp build every time a file gets saved with invalid / breaking CoffeeScript is annoying, @sinan had mentioned that this would be a "nice to have" -- and after today's nth gulp restart I decided to add it :)
I talked with some of the Gulp devs in IRC, and they said that this type of error handling for watch tasks will be handled in a future release