This repository was archived by the owner on Nov 25, 2020. It is now read-only.
ListView: Prevent unregisterItem method to delete item from listView #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@usirin made a refactor to this lately, umut can you take a look at this please? |
| @@ -191,7 +191,6 @@ module.exports = class KDListViewController extends KDViewController | |||
| @emit 'UnregisteringItem', itemInstance, index | |||
| actualIndex = @getIndex index | |||
|
|
|||
| @getListItems().splice actualIndex, 1 | |||
There was a problem hiding this comment.
Can we remove the actualIndex variable as well. Other than tat, LGTM.
(causes duplicate deletion)
…Item -> emits event test
szkl
pushed a commit
that referenced
this pull request
Aug 16, 2014
ListView: Prevent unregisterItem method to delete item from listView
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I delete an item from listView, two deletion operation was occurring as: one under listViewController->unregisterItem, the other one in listView->removeItem
Not sure if it is ok to remove this line from listViewController, but again as a counterpart, i expect registerItem to add item to listView, but it is not.
Also i did not see any other add/remove operator in listViewController, so I deleted it with the tests. :)