This repository was archived by the owner on Nov 25, 2020. It is now read-only.
Fix test #83
Merged
Fix test #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the dependencies.
gulp-karma requires karma-mocha and the browser runners, I guess what basically
gulp-karmais that it's just an interface for gulp to karma, it still requires you to add the dependencies.Changed the
npm testscript to run a gulp task which I introduced in this PR as well. basically we now have another karma config file for just running tests in travis, and there is a special task for that in gulp as well.