This repository was archived by the owner on Nov 25, 2020. It is now read-only.
splitview: add an option to forceResize all panels #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatihacet
added a commit
that referenced
this pull request
Nov 21, 2014
splitview: add an option to forceResize all panels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the following problem via adding another parameter called
forceResizeto the_calculateSizemethod.I know this is kind of a dirty solution, but I am taking notes of these kind of situations, and will try to address them in a proper way, hopefully, when we rewrite/refactor these components. Also, this kind of modification gives us a way to solve those kind of problems without breaking backwards compatibility.