disable task-based parallel on windows #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 36 36
Lines 779 779
Branches 74 74
=======================================
Hits 730 730
Misses 49 49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/openmp:llvmbrings the dependency onlibomp140.dll, which is not included in MSVC redistables and thus forces the user to install the whole Visual Studio. Because it seems/openmpdoesn't cause such a dependency, I choose to remove/openmp:llvmand task-based parallel. This change would result in a speed degradation for downsampling. But the majority of the package is still parallelized, and the influence to the total processing time should be minor.