Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Support offline transaction signing #140

Closed
4 tasks done
youkaicountry opened this issue Nov 7, 2022 · 0 comments · Fixed by #164
Closed
4 tasks done

[FEATURE]: Support offline transaction signing #140

youkaicountry opened this issue Nov 7, 2022 · 0 comments · Fixed by #164
Assignees
@youkaicountry
Labels
enhancement New feature or request story

Comments

@youkaicountry
Copy link
Contributor

youkaicountry commented Nov 7, 2022 •
edited
Loading

As a CLI user I would like the ability to sign transactions offline and submit transactions which were created offline.

Is there an existing issue for this?

  • I have searched the existing issues

New feature

  • Manually override nonces, auto fetches via rpc. Integer value uses that value.
  • Transaction builder should display json & base64 encoding of the signed transaction, if cli is in offline mode
  • Add a new command to submit a base64 encoded transaction

Anything else?

No response
@youkaicountry youkaicountry added enhancement New feature or request story labels Nov 7, 2022
@youkaicountry youkaicountry self-assigned this Nov 7, 2022
This was referenced Nov 10, 2022
Closed
Closed
youkaicountry added a commit that referenced this issue Nov 28, 2022
@youkaicountry
Involves #140
31e3bfa 
Add nonce and chainid commands, allow offline transaction signing
youkaicountry added a commit that referenced this issue Nov 28, 2022
@youkaicountry
Involves #140
4677e45 
Involves #163
Fix nonce issues
youkaicountry added a commit that referenced this issue Nov 29, 2022
@youkaicountry
Involves #140
0c7a873 
Bump util
mvandeberg added a commit that referenced this issue Nov 29, 2022
@mvandeberg
#140: Use non object based util transaction package
d96ec82
mvandeberg added a commit that referenced this issue Nov 29, 2022
@mvandeberg
#140: Fix transaction submission
e9a8312
mvandeberg added a commit that referenced this issue Nov 29, 2022
@mvandeberg
#140: Fix linting errors and incorrect nonce management
fef3476
youkaicountry added a commit that referenced this issue Nov 30, 2022
@youkaicountry
Involves #140
81200a5 
Rename chainid -> chain_id
Rename submit -> submit_transaction
@youkaicountry youkaicountry mentioned this issue Dec 1, 2022
Merged
5 tasks
youkaicountry added a commit that referenced this issue Dec 1, 2022
@youkaicountry
Involves #140
452afe5 
Add modified rpc client to support offline transaction signing
youkaicountry added a commit that referenced this issue Dec 1, 2022
@youkaicountry
Involves #140
b7ccf6b 
Address review comments
mvandeberg added a commit that referenced this issue Dec 1, 2022
@mvandeberg
#140: Add sign_transaction command for multisig
c2913ee
mvandeberg added a commit that referenced this issue Dec 1, 2022
@mvandeberg
#140: Redo session checks (sorry Nathan) and add json formatting for …
671ec2f 
…sign_transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youkaicountry youkaicountry

Labels
enhancement New feature or request story
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Offline transaction signing koinos/koinos-cli
Offline transaction signing koinos/koinos-cli
1 participant
@youkaicountry