Change default RC limit to 10%, show more helpful error messages #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandeberg
reviewed
Feb 27, 2023
internal/cli/interpreter.go
Outdated
| return err | ||
| } | ||
| result.AddErrorMessage(fmt.Sprintf("Current RC limit: %v, RC available: %v", decValue, decRc)) | ||
| result.AddErrorMessage(fmt.Sprintf("Try using a higher RC limit. Example: rclimit %v", decRc)) |
There was a problem hiding this comment.
I don't think we should immediately recommend going max rclimit. That somewhat defeats the purpose of this issue.
I would do the min of the current rclimit * 2 and the account's max rc.
mvandeberg
reviewed
Feb 27, 2023
internal/cli/interpreter.go
Outdated
| return err | ||
| } | ||
| result.AddErrorMessage(fmt.Sprintf("Current rc limit: %v%%", resultVal)) | ||
| result.AddErrorMessage("Try using a higher RC limit. Example: rclimit 100%") |
There was a problem hiding this comment.
Again, do we want to recommend 100% immediately again?
mvandeberg
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
Brief description
Changes the default rc limit to 10%, and gives more instructive error messages
Checklist
Demonstration