Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 10 #81

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Support Laravel 10 #81

merged 1 commit into from
Feb 24, 2023

Conversation

mtawil
Copy link
Contributor

@mtawil mtawil commented Feb 21, 2023

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Filament Import?
Put an x in the boxes that apply

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@pathros
Copy link

pathros commented Feb 23, 2023

Maybe that's why at the moment I'm getting the following error:

In Laravel 10, when trying to install this package,

❯ composer require konnco/filament-import

I get the following error:

Your requirements could not be resolved to an installable set of packages.

Problem 1: - konnco/filament-import[0.0.1, ..., 0.0.2, 1.0.0, ..., 1.4.2] require illuminate/contracts ^9.0 -> found illuminate/contracts[v9.0.0, ..., v9.52.4] but these were not loaded, likely because it conflicts with another require.

  • Root composer.json requires konnco/filament-import * -> satisfiable by konnco/filament-import[0.0.1, 0.0.2, 1.0.0, ..., 1.4.2].

You can also try re-running composer require with an explicit version constraint, e.g. "composer require konnco/filament-import:*" to figure out if any version is installable, or "composer require konnco/filament-import:^2.1" if you know which you need.

????

@frankyso
Copy link
Member

thanks

@frankyso frankyso merged commit 838595c into konnco:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants