Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added vars references (#DS-2679) WIP #40

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Aug 9, 2024

Variable references to each other

This makes it easier to track global variables:

  • Identify where they are declared.
  • See where they are used.
  • Understand how they are referenced.
image

@NikGurev NikGurev added the enhancement New feature or request label Aug 9, 2024
@NikGurev NikGurev requested a review from pimenovoleg August 9, 2024 17:01
@NikGurev NikGurev self-assigned this Aug 9, 2024
@NikGurev NikGurev marked this pull request as ready for review August 12, 2024 09:15
@NikGurev NikGurev force-pushed the feat/DS-2679 branch 2 times, most recently from ae83758 to 114f288 Compare August 12, 2024 11:30
@pimenovoleg pimenovoleg changed the title feat: transformed theme-specific global vars to theme-agnostic , added vars references feat: transformed theme-specific global vars to theme-agnostic , added vars references (#DS-2679) Aug 12, 2024
@pimenovoleg
Copy link
Contributor

@NikGurev
При сборке следующие моменты:

1. null значения
в css-tokens-font.css много null значение, например,
--kbq-code-block-font-hljs-template-variable-font-weight: null;
нормально ли это?

2. во время сборки
Появились warning, раньше их не было.

While building css-tokens-font.css, filtered out token references were found; output may be unexpected. Here are the references that are used but not defined in the file typography.subheading.line-height

В сборке button

⚠️ dist/design-tokens/web/components/styles/button.css While building button.css, token collisions were found; output may be unexpected. Output name kbq-button-toggle-container-background was generated by: button-toggle.light.container.background hsla(229, 15%, 92%, 100%)

Есть способ разрешить warnings?

@NikGurev
Copy link
Contributor Author

NikGurev commented Aug 13, 2024

@pimenovoleg

  1. Это конкретные значения токенов, с генерацией токенов проблем нет
  1. в 3 версии ошибки кастомить не получится: Feature request: Log level control for pre-defined formats amzn/style-dictionary#814 (comment). Закастомил через перезаписывание console.log

@NikGurev NikGurev changed the title feat: transformed theme-specific global vars to theme-agnostic , added vars references (#DS-2679) feat: transformed theme-specific global vars to theme-agnostic , added vars references (#DS-2679) WIP Aug 14, 2024
@NikGurev NikGurev changed the title feat: transformed theme-specific global vars to theme-agnostic , added vars references (#DS-2679) WIP feat: added vars references & build for each component (#DS-2679) WIP Aug 15, 2024
@NikGurev NikGurev changed the base branch from main to feat/DS-2755 August 15, 2024 12:59
Base automatically changed from feat/DS-2755 to main August 15, 2024 17:11
@NikGurev NikGurev force-pushed the feat/DS-2679 branch 3 times, most recently from 4819f6c to 0b20ba8 Compare August 19, 2024 16:22
@NikGurev NikGurev changed the title feat: added vars references & build for each component (#DS-2679) WIP feat: added vars references (#DS-2679) WIP Sep 2, 2024
@NikGurev NikGurev changed the title feat: added vars references (#DS-2679) WIP feat: added vars references (#DS-2679) Sep 2, 2024
@NikGurev NikGurev requested a review from artembelik September 2, 2024 10:00
@NikGurev NikGurev changed the title feat: added vars references (#DS-2679) feat: added vars references (#DS-2679) WIP Sep 18, 2024
@NikGurev NikGurev marked this pull request as draft September 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants