Add support for adding type hints to functions #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For type hints to be practically useful for runtime checks, for now they're going to have to be non-generic to avoid having to worry about (e.g.) checking every element in a list to see if it matches `List<String>`. In the future perhaps some strategies will be figured out for efficient runtime checks, but for now we can simplify the parser and AST by making it clear that types can't be nested.
Pipe detection was originally moved from the lexer to the parser in eee1a9c to support parsing generic types, but given that we're not going to support generic types any time soon I think it's better to roll back to the simpler implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for type hints on function arguments and on the function's return type.
The
>>pipe operator has been replaced with->to match the function output type syntax, which avoids there being two unique syntax elements related to function output.Additionally numbers now report their types as
Numberrather thanIntorFloat.#298