Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .sha2(.sha256) for PBKDF2 in readme #1061

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Use .sha2(.sha256) for PBKDF2 in readme #1061

merged 1 commit into from
Dec 9, 2024

Conversation

sjudd
Copy link
Contributor

@sjudd sjudd commented Dec 9, 2024

.sha256 is deprecated if I'm reading this right.

Fixes #

Checklist:

  • Correct file headers (see CONTRIBUTING.md).
  • Formatted with SwiftFormat.
  • Tests added.

Changes proposed in this pull request:

  • Replace a deprecated call in an example in the readme with a non-deprecated equivalent.

@sjudd
Use .sha2(.sha256) for PBKDF2 in readme
62b88be 
.sha256 is deprecated if I'm reading this right. 

Signed-off-by: Sam <[email protected]>
@sjudd sjudd requested a review from krzyzanowskim as a code owner December 9, 2024 18:59
krzyzanowskim
krzyzanowskim approved these changes Dec 9, 2024
View reviewed changes
Copy link
Owner

@krzyzanowskim krzyzanowskim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@krzyzanowskim krzyzanowskim merged commit 488e309 into krzyzanowskim:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzanowskim krzyzanowskim krzyzanowskim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjudd @krzyzanowskim