Fix Localmodel agent build #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenmoon55
force-pushed
the
localmodel-agent-build
branch
from
d23dc6e to
4aab193
Compare
Signed-off-by: Jin Dong <[email protected]>
greenmoon55
force-pushed
the
localmodel-agent-build
branch
from
4aab193 to
b096ccb
Compare
Signed-off-by: Jin Dong <[email protected]>
Signed-off-by: Jin Dong <[email protected]>
greenmoon55
commented
Dec 23, 2024
| @@ -24,6 +24,7 @@ env: | |||
| # Controller images | |||
| CONTROLLER_IMG: "kserve-controller" | |||
| LOCALMODEL_CONTROLLER_IMG: "kserve-localmodel-controller" | |||
| LOCALMODEL_AGENT_IMG: "kserve-localmodelnode-agent" | |||
There was a problem hiding this comment.
I prefer localmodel-agent but this is what we used in all the configs.
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Dec 24, 2024
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]>
yuzisun
pushed a commit
to yuzisun/kserve
that referenced
this pull request
Dec 24, 2024
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]>
yuzisun
added a commit
that referenced
this pull request
Dec 25, 2024
* Remove redundant namespace yaml (#4148) Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]> * Fix Localmodel agent build (#4150) * squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]> * Fix model server fails to gracefully shutdown (#4116) * Fix model server fails to gracefully shutdown Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update unit tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Dan Sun <[email protected]> Signed-off-by: Dan Sun <[email protected]> * Ensure root model directory exists and add protection for jobs created (#4152) Ensure root model directory exists and add protection for # of jobs created Signed-off-by: Dan Sun <[email protected]> * fix merge Signed-off-by: Dan Sun <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Jin Dong <[email protected]> Co-authored-by: Sivanantham <[email protected]>
bentohset
pushed a commit
to bentohset/kserve
that referenced
this pull request
Dec 26, 2024
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: bentohset <[email protected]>
bentohset
pushed a commit
to bentohset/kserve
that referenced
this pull request
Dec 26, 2024
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: bentohset <[email protected]>
Jooho
pushed a commit
to Jooho/kserve
that referenced
this pull request
Feb 11, 2025
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]>
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/kserve
that referenced
this pull request
Feb 20, 2025
* squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> (cherry picked from commit cb38637)
openshift-merge-bot bot
pushed a commit
to opendatahub-io/kserve
that referenced
this pull request
Mar 12, 2025
* Remove redundant namespace yaml (kserve#4148) Signed-off-by: Jin Dong <[email protected]> * Fix Localmodel agent build (kserve#4150) * squash commits Signed-off-by: Jin Dong <[email protected]> * localmodel agent -> localmodelnode agent Signed-off-by: Jin Dong <[email protected]> * Revert change Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> * Fix model server fails to gracefully shutdown (kserve#4116) * Fix model server fails to gracefully shutdown Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update unit tests Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Dan Sun <[email protected]> * Ensure root model directory exists and add protection for jobs created (kserve#4152) Ensure root model directory exists and add protection for # of jobs created Signed-off-by: Dan Sun <[email protected]> * Enable transformer deeper readiness check tests (kserve#4121) Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Update HuggingFace server dependencies versions (kserve#4147) * updated package versions Signed-off-by: ayush <[email protected]> * updated go.mod and pip Signed-off-by: ayush <[email protected]> * updated poetry lock Signed-off-by: ayush <[email protected]> * refactored handling of task argument Signed-off-by: ayush <[email protected]> * removed go.mod changes Signed-off-by: ayush <[email protected]> --------- Signed-off-by: ayush <[email protected]> * Add workflow for verifying go mod (kserve#4137) * Add workflow for verifying go mod Signed-off-by: Sivanantham Chinnaiyan <[email protected]> * Merge with go lint workflow Signed-off-by: Sivanantham Chinnaiyan <[email protected]> --------- Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Co-authored-by: Dan Sun <[email protected]> * Fix for CVE-2024-52304 - aiohttp upgrade (kserve#4113) upgrade aiohttp Signed-off-by: Andrews Arokiam <[email protected]> Co-authored-by: Dan Sun <[email protected]> * Allow other engine builders other than docker (kserve#3906) * Allow other engine builds other than docker chore: This change will allow user to use other engine builds. In addition, for Podman/Buildah engine builder, users can set the target architecture, useful when using ARM and there is a need to build x86 Container images. Can be done with `ENGINE=podman ARCH="--arch x86_64" make docker...` Signed-off-by: Spolti <[email protected]> * review changes Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]> * Add localmodelnode crd to helm chart (kserve#4161) Signed-off-by: Jin Dong <[email protected]> * Fixes Non-linear parsing of case-insensitive content (kserve#4158) * Fixes Non-linear parsing of case-insensitive content chore: Fixes CVE-2024-45338 Non-linear parsing of case-insensitive content in golang.org/x/net/html https://github.com/kserve/kserve/security/dependabot/1871 Signed-off-by: Spolti <[email protected]> * update go.sum Signed-off-by: Spolti <[email protected]> --------- Signed-off-by: Spolti <[email protected]> * Helm chart - option to run daemonset as root (kserve#4164) * Helm chart - option to run daemonset as root Signed-off-by: Jin Dong <[email protected]> * make generate Signed-off-by: Jin Dong <[email protected]> * Revert default values Signed-off-by: Jin Dong <[email protected]> * Fix job count test Signed-off-by: Dan Sun <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Dan Sun <[email protected]> Co-authored-by: Dan Sun <[email protected]> * Replace nodeGroup with nodeGroups in charts/kserve-crd (kserve#4166) Replace nodeGroup with nodeGroups Signed-off-by: Rituraj Singh <[email protected]> Co-authored-by: Rituraj Singh <[email protected]> * Add affinity and tolerations to localmodel daemonset (kserve#4173) * Add affinity and tolerations to localmodel daemonset Signed-off-by: Jin Dong <[email protected]> * make generate Signed-off-by: Jin Dong <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> * Fix s3 download PermanentRedirectError for legacy s3 endpoint (kserve#4157) * sets virtual addressing style for legacy s3 endpoint Signed-off-by: bentohset <[email protected]> * add unit test Signed-off-by: bentohset <[email protected]> * fix formatting Signed-off-by: bentohset <[email protected]> * fix unit tests Signed-off-by: bentohset <[email protected]> --------- Signed-off-by: bentohset <[email protected]> Co-authored-by: Lize Cai <[email protected]> --------- Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Sivanantham Chinnaiyan <[email protected]> Signed-off-by: Dan Sun <[email protected]> Signed-off-by: ayush <[email protected]> Signed-off-by: Andrews Arokiam <[email protected]> Signed-off-by: Spolti <[email protected]> Signed-off-by: Jin Dong <[email protected]> Signed-off-by: Rituraj Singh <[email protected]> Signed-off-by: bentohset <[email protected]> Co-authored-by: Jin Dong <[email protected]> Co-authored-by: Sivanantham <[email protected]> Co-authored-by: Dan Sun <[email protected]> Co-authored-by: Ayush Sawant <[email protected]> Co-authored-by: Andrews Arokiam <[email protected]> Co-authored-by: Filippe Spolti <[email protected]> Co-authored-by: Rituraj Singh <[email protected]> Co-authored-by: Rituraj Singh <[email protected]> Co-authored-by: Benjamin Toh <[email protected]> Co-authored-by: Lize Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We never build localmodel agent images in our workflow.
I also renamed the docker file from node to agent to avoid confusion in other files like workflow files.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.