Add well-known label to InferenceGraphs #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rerun-all |
1 similar comment
|
/rerun-all |
We require to add an `AuthorizationPolicy` to the resulting pods of InferenceGraph (serverless mode). In Istio, Workload Selectors require a <key, value> pair. Apparently, there is no support to match only on the presence of a label key. See https://istio.io/latest/docs/reference/config/type/workload-selector/#WorkloadSelector. Thus, to correctly apply AuthorizationPolicies, this is adding the `serving.kserve.io/kind: InferenceGraph` to pods that belong to InferenceGraph. Signed-off-by: Edgar Hernández <[email protected]>
yuzisun
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We require to add an
AuthorizationPolicyto the resulting pods of InferenceGraph (serverless mode). In Istio, Workload Selectors require a <key, value> pair. Apparently, there is no support to match only on the presence of a label key (it needs to be both <key,value>). See https://istio.io/latest/docs/reference/config/type/workload-selector/#WorkloadSelector.Thus, to correctly apply AuthorizationPolicies, this is adding the
serving.kserve.io/kind: InferenceGraphlabel to pods that belong to InferenceGraph.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):N/A
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Deploying an InferenceGraph in Serverless mode. Verify that the new label is present in the resulting pods.
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.