-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golangci-lint verstion to 1.64 #4302
update golangci-lint verstion to 1.64 #4302
Conversation
Signed-off-by: Jooho Lee <[email protected]>
Signed-off-by: Jooho Lee <[email protected]>
/rerun-all |
I think the ci failure has nothing to do with this change. What I just changed is golangci-lint version and did
@sivanantha321 @terrytangyuan WDYT? |
It is failing due to name conflict. It is not related to the PR. |
ok let me send another pr to change the name |
I believe @andyi2it is already working on this :) |
/rerun-workflow "Transformer Docker Publisher / test-transformer-grpc (pull_request)" |
/rerun-workflow "Transformer Docker Publisher" |
/rerun-all |
4 similar comments
/rerun-all |
/rerun-all |
/rerun-all |
/rerun-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
What this PR does / why we need it:
golangci-lint 1.63 failed to execute with the following msg
CI is not using verify-golint.sh file and actually the gitaction ci is using 1.64 so there is no issue in ci.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.