Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint verstion to 1.64 #4302

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Mar 11, 2025

What this PR does / why we need it:
golangci-lint 1.63 failed to execute with the following msg

ERRO Running error: can't run linter goanalysis_metalinter
goanalysis_metalinter: gofumpt: package "types" (isInitialPkg: true, needAnalyzeSource: true): invalid line number 572 (should be < 570) 

CI is not using verify-golint.sh file and actually the gitaction ci is using 1.64 so there is no issue in ci.

Checking for go.mod: go.mod
  Warning: Cache not found for keys: golangci-lint.cache-Linux-2879-71d21110d53287cb9136ed1165bb547af3eb7b01, golangci-lint.cache-Linux-2879-
  Cache not found for input keys: golangci-lint.cache-Linux-2879-71d21110d53287cb9136ed1165bb547af3eb7b01, golangci-lint.cache-Linux-2879-
  Finding needed golangci-lint version...
  Requested golangci-lint 'v1.63', using 'v1.63.4', calculation took 37ms
  Installation mode: binary
  Installing golangci-lint binary v1.63.4...
  Downloading binary https://github.com/golangci/golangci-lint/releases/download/v1.63.4/golangci-lint-1.63.4-linux-amd64.tar.gz ...
  /usr/bin/tar xz --overwrite --warning=no-unknown-keyword --overwrite -C /home/runner -f /home/runner/work/_temp/c058933b-c76e-4081-8e72-3a[15](https://github.com/kserve/kserve/actions/runs/13765828976/job/38491933727?pr=4297#step:4:16)62a20ed5
  Installed golangci-lint into /home/runner/golangci-lint-1.63.4-linux-amd64/golangci-lint in 780ms
  Prepared env in 1053ms

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

@Jooho
Copy link
Contributor Author

Jooho commented Mar 12, 2025

/rerun-all

@Jooho
Copy link
Contributor Author

Jooho commented Mar 12, 2025

I think the ci failure has nothing to do with this change. What I just changed is golangci-lint version and did

  • make go-lint py-lint

@sivanantha321 @terrytangyuan WDYT?

@sivanantha321
Copy link
Member

I think the ci failure has nothing to do with this change. What I just changed is golangci-lint version and did

  • make go-lint py-lint

@sivanantha321 @terrytangyuan WDYT?

It is failing due to name conflict. It is not related to the PR.

@Jooho
Copy link
Contributor Author

Jooho commented Mar 12, 2025

ok let me send another pr to change the name

@sivanantha321
Copy link
Member

ok let me send another pr to change the name

I believe @andyi2it is already working on this :)

@Jooho
Copy link
Contributor Author

Jooho commented Mar 12, 2025

/rerun-workflow "Transformer Docker Publisher / test-transformer-grpc (pull_request)"

@Jooho
Copy link
Contributor Author

Jooho commented Mar 12, 2025

/rerun-workflow "Transformer Docker Publisher"

@Jooho
Copy link
Contributor Author

Jooho commented Mar 13, 2025

/rerun-all

4 similar comments
@Jooho
Copy link
Contributor Author

Jooho commented Mar 13, 2025

/rerun-all

@Jooho
Copy link
Contributor Author

Jooho commented Mar 13, 2025

/rerun-all

@Jooho
Copy link
Contributor Author

Jooho commented Mar 13, 2025

/rerun-all

@Jooho
Copy link
Contributor Author

Jooho commented Mar 13, 2025

/rerun-all

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@terrytangyuan terrytangyuan merged commit d0b7f31 into kserve:master Mar 13, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants