Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] migrate docker images to ghcr #2520

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2519

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mahdikhashan mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from 24a1d7a to 47bddb3 Compare February 27, 2025 11:29
@mahdikhashan
Copy link
Member Author

mahdikhashan commented Feb 27, 2025

/cc @kubeflow/wg-automl-leads @Electronic-Waste @varodrig

PTAL!

@google-oss-prow google-oss-prow bot requested review from varodrig and a team February 27, 2025 11:30
@mahdikhashan
Copy link
Member Author

please refer to this published image on my own user, https://github.com/mahdikhashan/katib/pkgs/container/katib-conformance

and this temp workflow where i disabled release branch check: https://github.com/mahdikhashan/katib/actions/runs/13565650050/job/37918014229

@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Feb 27, 2025
@mahdikhashan mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from d9e30ac to 503fa11 Compare February 27, 2025 12:08
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
@mahdikhashan mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from 503fa11 to 213242d Compare February 27, 2025 12:08
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahdikhashan Thanks for this! Just one comment for you.

@@ -45,7 +41,7 @@ jobs:
id: publish
uses: ./.github/workflows/template-publish-image
with:
image: docker.io/kubeflowkatib/${{ inputs.component-name }}
image: ghcr.io/kubeflowkatib/${{ inputs.component-name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the naming convention in GHCR should be ghcr.io/<org name or user name>/....

So the second item between /s might need to be changed to kubeflow

@Electronic-Waste
Copy link
Member

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

@mahdikhashan
Copy link
Member Author

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

tnx for your review Shao, will address them asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate images in Dockerhub to GHCR
2 participants