-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] migrate docker images to ghcr #2520
base: master
Are you sure you want to change the base?
[feature] migrate docker images to ghcr #2520
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
24a1d7a
to
47bddb3
Compare
/cc @kubeflow/wg-automl-leads @Electronic-Waste @varodrig PTAL! |
please refer to this published image on my own user, https://github.com/mahdikhashan/katib/pkgs/container/katib-conformance and this temp workflow where i disabled release branch check: https://github.com/mahdikhashan/katib/actions/runs/13565650050/job/37918014229 |
d9e30ac
to
503fa11
Compare
Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
503fa11
to
213242d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahdikhashan Thanks for this! Just one comment for you.
@@ -45,7 +41,7 @@ jobs: | |||
id: publish | |||
uses: ./.github/workflows/template-publish-image | |||
with: | |||
image: docker.io/kubeflowkatib/${{ inputs.component-name }} | |||
image: ghcr.io/kubeflowkatib/${{ inputs.component-name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, the naming convention in GHCR should be ghcr.io/<org name or user name>/...
.
So the second item between /
s might need to be changed to kubeflow
And maybe we should also fix the image reference under |
tnx for your review Shao, will address them asap. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2519
Checklist: