Upgrade Kubernetes Version to 1.32.2 #2521
Conversation
…elease-0.20. Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
google-oss-prow
bot
requested review from
mahdikhashan,
Doris-xm,
a team and
helenxie-bit
|
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: truc0. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Electronic-Waste
force-pushed
the
feat/upgrade-k8s-1.32
branch
from
b7eea92 to
69230b5
Compare
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
There was a problem hiding this comment.
This PR is ready for the review. PTAL if you have time👀
@kubeflow/wg-automl-leads @helenxie-bit @mahdikhashan @Doris-xm @truc0
| succeededBatchJobName = "test-job-succeeded" | ||
| failedBatchJobName = "test-job-failed" |
There was a problem hiding this comment.
We need to separate the Trial run with "Failed" BatchJob. test and other tests. That's because:
- If a Job is succeeded, we need to set
CompleteandSuccessCriteriaMetConditions in the Job status - If a Job is failed, we need to set
FailedandFailureTargetConditions in the Job status
And we can't mutate these completion conditions, or we will get:
Invalid value: cannot disable the terminal Failed=True condition, status.conditions: Invalid value: cannot disable the terminal FailureTarget=True condition,
So we need to separate these UTs with two different Job Names.
| // TODO(Electronic-Waste): Remove this condition when K8s 1.30 is no longer supported. | ||
| // SuccessPolicy is available in K8s 1.31 and later. If we set it in K8s 1.30, it will be ignored. | ||
| // And when we set the status with `SuccessCriteriaMet`, it will report error: | ||
| // "Invalid value: cannot set SuccessCriteriaMet=True for Job without SuccessPolicy". | ||
| // REF: https://kubernetes.io/docs/concepts/workloads/controllers/job/#success-policy | ||
| isK8sVersion130 := strings.Contains(os.Getenv("KUBEBUILDER_ASSETS"), "1.30") |
There was a problem hiding this comment.
We need to remove this when we do not plan to support Kubernetes v1.30.
Related CI error: https://github.com/kubeflow/katib/actions/runs/13613616097/job/38053846460
|
/rerun-all |
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
| @@ -33,7 +33,7 @@ fmt: | |||
|
|
|||
| lint: | |||
| ifndef HAS_LINT | |||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.2 | |||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.1 | |||
There was a problem hiding this comment.
Update this because support for Go 1.23 starts from v1.60.1
|
/rerun-all |
What this PR does / why we need it:
We should support the latest k8s v1.32 release https://github.com/kubernetes/kubernetes/releases/tag/v1.32.2.
Kubeflow Trainer has decided to support Kubernetes v1.32 kubeflow/trainer#2434. We'd better upgrade the Kubernetes version to maintain consistency with Trainer.
/cc @kubeflow/wg-automl-leads @helenxie-bit @mahdikhashan @Doris-xm @truc0
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2516
Checklist: