Update the group of Service in the examples and tests #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group of Service can be either empty ("") or "v1", but not "core",
so as other resources (ConfigMap, Pod, Secret, PersistentVolumeClaim and
etc.).
k8s-ci-robot
added
cncf-cla: yes
|
/assign @barney-s |
barney-s
reviewed
Feb 10, 2020
| @@ -13,7 +13,7 @@ spec: | |||
| matchLabels: | |||
| app.kubernetes.io/name: "wordpress-01" | |||
| componentKinds: | |||
| - group: core | |||
| - group: v1 | |||
There was a problem hiding this comment.
I understand this change. Why change "" to v1 in the others ?
There was a problem hiding this comment.
per Janet's comment: #112 (comment).
It seems v1 makes more sense than "".
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group of Service can be either "v1" or empty (""), but not "core",
so as other resources (ConfigMap, Pod, Secret, PersistentVolumeClaim and
etc.).