Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine prometheus metrics #1230

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 18, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
chore: refine prometheus metrics

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

"Observed Request Latency" latency_seconds=2.488289745 request="azuredisk_csi_driver_controller_create_volume" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-8a9dk4r1/providers/Microsoft.Compute/disks/pvc-34bd9b6b-e3d7-4c24-bc5f-d76e206cbaca="" result_code="succeeded"
"Observed Request Latency" latency_seconds=5.252537262 request="azuredisk_csi_driver_controller_delete_volume" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-8a9dk4r1/providers/Microsoft.Compute/disks/pvc-34bd9b6b-e3d7-4c24-bc5f-d76e206cbaca="" result_code="succeeded"
"Observed Request Latency" latency_seconds=35.669521545 request="azuredisk_csi_driver_controller_publish_volume" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-8a9dk4r1/providers/Microsoft.Compute/disks/pvc-34bd9b6b-e3d7-4c24-bc5f-d76e206cbaca=k8s-agentpool1-35106576-1 result_code="succeeded"
"Observed Request Latency" latency_seconds=15.683682928 request="azuredisk_csi_driver_controller_unpublish_volume" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-8a9dk4r1/providers/Microsoft.Compute/disks/pvc-34bd9b6b-e3d7-4c24-bc5f-d76e206cbaca=k8s-agentpool1-35106576-1 result_code="succeeded"
"Observed Request Latency" latency_seconds=2.5004776079999997 request="azuredisk_csi_driver_controller_create_snapshot" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-8a9dk4r1/providers/Microsoft.Compute/disks/pvc-474d99a4-3561-40a0-a70f-17983abd8a2d="snapshot-cac2ced8-5684-44c7-96d9-1a2be1a5872c" result_code="succeeded"
"Observed Request Latency" latency_seconds=5.21112229 request="azuredisk_csi_driver_controller_delete_snapshot" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/azuredisk-csi-driver-test-cf17c544-a75f-11ec-8556-12364907c084/providers/Microsoft.Compute/snapshots/snapshot-cac2ced8-5684-44c7-96d9-1a2be1a5872c="" result_code="succeeded"
"Observed Request Latency" latency_seconds=0.020298546 request="azuredisk_csi_driver_controller_expand_volume" resource_group="kubetest-8a9dk4r1" subscription_id="0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e" source="disk.csi.azure.com" /subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/kubetest-

Release note:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@andyzhangx andyzhangx removed the request for review from edreed March 18, 2022 14:27
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-capz

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-capz

@andyzhangx andyzhangx changed the title [WIP]chore: refine prometheus metrics chore: refine prometheus metrics Mar 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2022
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-capz

1 similar comment
@andyzhangx
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-capz

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz 3301b8b link false /test pull-azuredisk-csi-driver-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 7309386 into kubernetes-sigs:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants