-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove deprecated flag for old infra machine naming #11679
⚠️ Remove deprecated flag for old infra machine naming #11679
Conversation
/cc @lentzi90 |
Could we get #11172 merged first? |
/hold |
Yup, absolutely. I should get around to 11172 soon |
@mboersma You probably saw it already, PR is now merged so we can rebase this PR and get it merged as well :) |
35b6b0c
to
db7e7a9
Compare
/hold cancel #11172 merged and I rebased this afterward. |
db7e7a9
to
f54d6f8
Compare
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 70cfbcb735bbcc840276229b367cc193abbed150
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Removes the flag
--use-deprecated-infra-machine-naming
, which was planned to disappear in CAPI v1.9.Which issue(s) this PR fixes:
Refs #10576
Refs #11172
/area provider/control-plane-kubeadm
/area machineset