Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize ConfigMapGenerator, SecretGenerator #4989

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Localize ConfigMapGenerator, SecretGenerator #4989

merged 1 commit into from
Jan 27, 2023

Conversation

annasong20
Copy link
Contributor

This PR localizes the custom transformers ConfigMapGenerator and SecretGenerator.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2023
@annasong20
Copy link
Contributor Author

/cc @yuwenma

@k8s-ci-robot k8s-ci-robot requested a review from yuwenma January 19, 2023 01:37
@annasong20
Copy link
Contributor Author

/retest

@annasong20 annasong20 force-pushed the localize-generators-configmap-secret branch 2 times, most recently from b80fda6 to 1b8c465 Compare January 25, 2023 01:10
yuwenma
yuwenma approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@yuwenma
Copy link
Contributor

yuwenma commented Jan 26, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 26, 2023
natasha41575
natasha41575 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@annasong20 annasong20 force-pushed the localize-generators-configmap-secret branch from 1b8c465 to 142360b Compare January 27, 2023 22:06
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 27, 2023
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit ee4fb17 into kubernetes-sigs:master Jan 27, 2023
@annasong20 annasong20 deleted the localize-generators-configmap-secret branch January 27, 2023 22:22
@Striar-Yunis Striar-Yunis mentioned this pull request May 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma approved these changes

@natasha41575 natasha41575 natasha41575 approved these changes

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@yuwenma yuwenma

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annasong20 @yuwenma @k8s-ci-robot @natasha41575