Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pprof #250

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix pprof #250

merged 1 commit into from
Feb 2, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Feb 2, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The original is the copy below, but that doesn't work.

https://github.com/kubernetes/kubernetes/blob/b46a3f887ca979b1a5d14fd39cb1af43e7e5d12d/pkg/kubelet/server/server.go#L602-L634

Does this PR introduce a user-facing change?

Fix pprof for kwok controller

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2023
@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit a4cb880
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/63dbd050b68fbb000ad68fa6

@wzshiming wzshiming merged commit 9a8d272 into kubernetes-sigs:main Feb 2, 2023
@wzshiming wzshiming deleted the fix/pprof branch February 2, 2023 15:56
@wzshiming wzshiming restored the fix/pprof branch February 11, 2023 16:16
wzshiming added a commit that referenced this pull request Feb 12, 2023
…upstream-release-0.1

Automated cherry pick of #250: Fix pprof
@wzshiming wzshiming mentioned this pull request Feb 20, 2023
9 tasks
@wzshiming wzshiming deleted the fix/pprof branch February 20, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants