initialize nodeSelectorFunc when --manage-nodes-with-label-selector is set

[lzlaa]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The reason why #346 happened is that kwok doesn't initialize nodeSelectorFunc when --manage-nodes-with-label-selector is set, this PR will initialize nodeSelectorFunc to fix it.

Which issue(s) this PR fixes:

Fixes #346

Special notes for your reviewer:

Kwok doesn't initializes nodeSelectorFunc when --manage-nodes-with-label-selector is set, so node_controller.go#L170 causes nil point panic.

Does this PR introduce a user-facing change?

Fix panic caused by `--manage-nodes-with-label-selector`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lzlaa / name: Zhilei Liu (a977809)

[netlify]

✅ Deploy Preview for k8s-kwok canceled.

Name	Link
🔨 Latest commit	4a43d57
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-kwok/deploys/64049d533f18100008b5dbf7

[k8s-ci-robot]

Welcome @lzlaa!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @lzlaa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wzshiming]

it's okay, squash commits. and can we have a test cover this change?

[wzshiming]

/ok-to-test

[lzlaa]

it's okay, squash commits. and can we have a test cover this change?

Thanks for your work, I add an unit test to cover this change.

[lzlaa]

I have resolved your comment. @wzshiming

[wzshiming]

/approve
/lgtm

Thank you for your contribution

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzlaa, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wzshiming]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment