Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the logic of the node leases and fix flake test #902

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jan 2, 2024

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #886 #899

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Optimize the logic of the node leases

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit a118781
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/659b8694bfc8df000877d518

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2024
@wzshiming wzshiming force-pushed the fix/node-lease branch 17 times, most recently from b87ac9f to 034a4f9 Compare January 3, 2024 08:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024
@wzshiming wzshiming force-pushed the fix/node-lease branch 2 times, most recently from 9efd447 to ed31d46 Compare January 3, 2024 08:54
@wzshiming wzshiming force-pushed the fix/node-lease branch 14 times, most recently from eff3eb8 to 596b47d Compare January 5, 2024 17:31
@wzshiming wzshiming changed the title [WIP] Optimize the logic of the node leases Optimize the logic of the node leases Jan 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@wzshiming wzshiming changed the title Optimize the logic of the node leases Optimize the logic of the node leases and fix flake test Jan 8, 2024
@wzshiming wzshiming changed the title Optimize the logic of the node leases and fix flake test [WIP] Optimize the logic of the node leases and fix flake test Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@wzshiming wzshiming changed the title [WIP] Optimize the logic of the node leases and fix flake test Optimize the logic of the node leases and fix flake test Jan 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@wzshiming wzshiming merged commit d4ff83a into kubernetes-sigs:main Jan 8, 2024
@wzshiming wzshiming deleted the fix/node-lease branch January 8, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants