Strategic Merge Patch doc #535
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @pwittrock |
| Example usage in the patch: | ||
|
|
||
| ``` | ||
| $patch: replace |
There was a problem hiding this comment.
Put the example in the context of an actual json struct. This doesn't show demonstrate how to create a patch with this directive.
There was a problem hiding this comment.
Nevermind, I should have kept reading :P
| To delete items "b" and "c" from the original finalizers, the patch will be: | ||
|
|
||
| ```yaml | ||
| $deleteFromPrimitiveList/finalizers: |
There was a problem hiding this comment.
Would you add the context around this like you did for the others?
|
Generally looks good. Just one comment about adding an example for the delete for primitives |
|
|
||
| ### Purpose | ||
|
|
||
| `delete` directive indicates that the element that contains it should be deleted. |
There was a problem hiding this comment.
Does this apply to maps, or just lists? Will maps setting to null is how items are deleted right?
There was a problem hiding this comment.
Does this apply to maps, or just lists?
Both map and list of maps.
Will maps setting to null is how items are deleted right?
That's one way. The other way is using delete directive in map.
I updated the doc to cover both.
| live: null # set the value of the map key to null | ||
| ``` | ||
|
|
||
| Details of Strategic Merge Patch is in this [doc](../strategic-merge-patch.md). |
|
Looks good, one minor comment then ready to merge. |
|
Addressed the comment. And squashed. |
|
Thanks! |
Pull Strategic Merge Patch out of API convention doc.
And refactor it.
Use the format what I discussed with @pwittrock offline.
More content need to be fill by @pwittrock in a followup PR.