Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2008: Graduate "Forensic Container Checkpointing" to GA #5090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianreber
Copy link
Contributor

As defined in the existing KEP the steps to graduate from Beta to GA are

CRI-O as well as containerd have to have implemented the corresponding CRI APIs:

  • CRI-O
  • containerd

Ensure that e2e tests are working with

  • CRI-O
  • containerd

Both requirements are fulfilled. containerd supports the corresponding CRI APIs since 2.0 and CRI-O since 1.25.

Tests are also running according to
https://storage.googleapis.com/k8s-triage/index.html?test=checkpoint#a3361808c39a7eb28162

  • One-line PR description: Graduate "Forensic Container Checkpointing" to GA

As defined in the existing KEP the steps to graduate from Beta to GA
are

  CRI-O as well as containerd have to have implemented the corresponding
  CRI APIs:

  - [x] CRI-O
  - [x] containerd

  Ensure that e2e tests are working with

  - [x] CRI-O
  - [x] containerd

Both requirements are fulfilled. containerd supports the corresponding
CRI APIs since 2.0 and CRI-O since 1.25.

Tests are also running according to
https://storage.googleapis.com/k8s-triage/index.html?test=checkpoint#a3361808c39a7eb28162

Signed-off-by: Adrian Reber <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @adrianreber. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianreber
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr, jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2025
@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@@ -354,6 +359,14 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
features enabled with CRI-O, no results have been collected and tests have
been skipped.

- Since the release of containerd 2.0 and CRI-O 1.25 and since the graduation of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev @mikebrow @samuelkarp do you think containerd 2.0 is new enough to consider the checkpoint CRI API GA?

@mrunalp
Copy link
Contributor

mrunalp commented Feb 11, 2025

Let's add the changes discussed in sig-node weekly meeting to make this opt-in through config at GA. Thanks!
cc: @mikebrow @dchen1107

@kannon92
Copy link
Contributor

cc @tallclair

kubernetes/kubernetes#130016

I guess making this opt in for GA would also help this CVE. As of now I read that the disablement of the checkpoint feature gate is the recommended approach to mitigate the CVE.

@tallclair
Copy link
Member

I guess making this opt in for GA would also help this CVE. As of now I read that the disablement of the checkpoint feature gate is the recommended approach to mitigate the CVE.

The issue is already fixed in v1.33, so we don't need to worry about mitigation strategies for this specific issue going forward. There may still be general concerns with checkpoints filling up the disk though, so cluster provisioners may still want to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants