Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric to show details of status condition of PVC resizing. #952

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Add metric to show details of status condition of PVC resizing. #952

merged 1 commit into from
Oct 28, 2019

Conversation

sinhaaks
Copy link
Contributor

What this PR does / why we need it:
Added new metric for PVC resize status
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #714

@k8s-ci-robot
Copy link
Contributor

Welcome @ankitsinhaiiitg!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from lilic and zouyee October 21, 2019 16:20
@tariq1890
Copy link
Contributor

@ankitsinhaiiitg Please don't forget to squash your commits :)

@sinhaaks sinhaaks force-pushed the aks-resizingStatusMetric branch from b940411 to 55313ed Compare October 21, 2019 18:17
@sinhaaks
Copy link
Contributor Author

@ankitsinhaiiitg Please don't forget to squash your commits :)

Done

@sinhaaks sinhaaks requested a review from tariq1890 October 21, 2019 18:30
@sinhaaks sinhaaks force-pushed the aks-resizingStatusMetric branch from 55313ed to 4d749b5 Compare October 25, 2019 21:19
@sinhaaks
-m ADD kube_persistentvolumeclaim_status_condition metric for informa…
fe07c8c 
…tion about status of different conditions of persistent volume claim.
@sinhaaks sinhaaks force-pushed the aks-resizingStatusMetric branch from 4d749b5 to fe07c8c Compare October 25, 2019 23:20
@zouyee
Copy link
Member

zouyee commented Oct 25, 2019

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2019
@sinhaaks
Copy link
Contributor Author

/assign @brancz

@tariq1890
Copy link
Contributor

@ankitsinhaiiitg You’re correct! Sorry about that.

Thank you so much for your contribution and your patience with this!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitsinhaiiitg, tariq1890, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9d35328 into kubernetes:master Oct 28, 2019
@sinhaaks
Copy link
Contributor Author

Thanks for merging and your support and guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 left review comments

@brancz brancz brancz left review comments

@lilic lilic Awaiting requested review from lilic

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@brancz brancz

@zouyee zouyee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New metric for PVC resize status
6 participants
@sinhaaks @k8s-ci-robot @tariq1890 @zouyee @brancz @lilic