Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown link #33857

Merged
merged 1 commit into from
May 26, 2022
Merged

Fix Markdown link #33857

merged 1 commit into from
May 26, 2022

Conversation

Sea-n
Copy link
Member

@Sea-n Sea-n commented May 20, 2022

  • Fix invalid [Slack](slack.k8s.io) link
  • Fix typo dockercfgjson to dockerconfigjson
  • Remove redundant spaces in [link]( url)
  • Add space in `foo`,`bar`

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 20, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 20, 2022
Arhell
Arhell reviewed May 21, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a98309f8903cb8e6e192b2d108d1b735777bfcee

@Arhell Arhell removed their assignment May 23, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@Sea-n
Copy link
Member Author

Sea-n commented May 25, 2022

(Force-pushed to fix build error caused by #33842)

@tengqm
Copy link
Contributor

tengqm commented May 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@netlify
Copy link

netlify bot commented May 25, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cca0aca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/628e2c5516f44700080be85d
😎 Deploy Preview https://deploy-preview-33857--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented May 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa82cdeedd92859b51a49d634d2563f16520cfdc

@k8s-ci-robot k8s-ci-robot merged commit f189916 into kubernetes:main May 26, 2022
@Sea-n Sea-n deleted the fix-link branch June 11, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sea-n @k8s-ci-robot @tengqm @Arhell