feat: policies list in the quick start page. #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an embedded HTML with the policies available in the ArtifactHub Signed-off-by: José Guilherme Vanz <[email protected]>
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flavio
reviewed
Jul 12, 2024
docs/quick-start.md
Outdated
Comment on lines
416
to
417
| chapters](tutorials/writing-policies/rego/01-intro-rego.md). Here is the list of | ||
| available policies on ArtifactHub: |
There was a problem hiding this comment.
Suggested change
| chapters](tutorials/writing-policies/rego/01-intro-rego.md). Here is the list of | |
| available policies on ArtifactHub: | |
| chapters](tutorials/writing-policies/rego/01-intro-rego.md). | |
| Finally, here is the list of available policies on ArtifactHub. |
There was a problem hiding this comment.
I think the @jhkrug approach a better way to list the policies and makes this suggestion obsolete. Therefore, I'll skip this change. Ok? ;)
viccuad
approved these changes
Jul 12, 2024
jhkrug
reviewed
Jul 12, 2024
Co-authored-by: John Krug <[email protected]> Signed-off-by: José Guilherme Vanz <[email protected]>
|
I prefer @jhkrug's approach. You can go ahead and merge this PR |
fabriziosestito
approved these changes
Jul 12, 2024
|
@jvanz I think it would be cool to embed as a widget rather than linking to artifactHub. The idea is to make it easier for users to directly interact with Kubewarden policies directly on kubewarden.io. You can take a look at some examples here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an embedded HTML with the policies available in the ArtifactHub
Fix #401