read customized values if they exists to make hook works. #2
Conversation
Currently, it doesn't read settings from $SNAP_COMMON/wekan_settings.sh which results in regarding customized settings doesn't take effect. e.g. port
be lower case instead of upper case. And revert the customized values reading from wekan_settings.sh file.
|
If we export keys which were not set, they will be overridden with default key value. See $SNAP/wekan-read-settings file So that's not a bug. |
|
Basically, if the keys which were not set will be overridden by using the default value. |
|
snapcraft yaml is out of sync. I will remove settings description from there completely, as now you can get all info by calling wekan.help. That is cleaner implementation as that reads from src/config key mapping rules. Like this we have central place where all key mapping and all other places are reading it from there. |
|
I like the idea of calling wekan.help to list all available key names from the command line. Indeed, It's cleaner than the hooks-fix branch implementation that just lists all of them in yaml file. |
|
I have it set on auto build, so all changes are already in the store. But I just noticed they have mad 0.12 release. So now building it |
Currently, it doesn't read settings from $SNAP_COMMON/wekan_settings.sh
which results in regarding customized settings doesn't take effect.
To verify it
sudo snap set wekan-ondra port=9876
sudo snap disable wekan-ondra
sudo snap enable wekan-ondra
Then navigate to localhost:9876 in your browser to check if you can open wekan website from you local.