Added conversion between julia infs and QPALM infs in the problem bounds #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NaN solutions after update.
Junk elimination
lostella
reviewed
Aug 30, 2019
| @@ -176,6 +176,10 @@ function update!( | |||
| ) | |||
| end | |||
|
|
|||
| # Convert lower and upper bounds from Julia infinity to OSQP infinity | |||
There was a problem hiding this comment.
Ah sorry, I merged this just a second ago. Will fix in a sec.
There was a problem hiding this comment.
Ah in fact, it was your fault Lorenzo as this comment came directly from the setup wrapper :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion was performed in setup and not in update!. So in the case in which the user would setup a model, then update it and finally solve it, the solve method would fail due to NaNs in the bounds.