Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] fails to transform code #156

Closed
pelotom opened this issue Apr 5, 2017 · 9 comments
Closed

[email protected] fails to transform code #156

pelotom opened this issue Apr 5, 2017 · 9 comments

Comments

@pelotom
Copy link
Contributor

pelotom commented Apr 5, 2017

I updated my library's ts-jest version from 19.0.6 to 19.0.7 and now typescript tests are apparently not getting transformed properly:

https://travis-ci.org/pelotom/runtypes/builds/218997722

@pelotom pelotom changed the title [email protected] doesn't work in Travis CI [email protected] fails to transform code Apr 5, 2017
pelotom added a commit to runtypes/runtypes that referenced this issue Apr 5, 2017
@kulshekhar
Copy link
Owner

@pelotom do you really need "target": "es6" in the jest globals in package.json?

@kulshekhar
Copy link
Owner

It passes if you remove "target": "es6"

@pelotom
Copy link
Contributor Author

pelotom commented Apr 5, 2017

Ah, so I am targeting es6 in order to avoid this issue with spurious missing coverage on super calls:

microsoft/TypeScript#13029

Do you know of another way to work around that? Also why is this suddenly an issue when it wasn't before?

@kulshekhar
Copy link
Owner

kulshekhar commented Apr 5, 2017

That's not required while testing though, right? I'm actually not sure about this

@kulshekhar
Copy link
Owner

If you target es6 during testing, that code is then passed to Jest which expects the transformed code in es5 format.

Actually, I'm not sure how this was working for you before 19.0.7!

@pelotom
Copy link
Contributor Author

pelotom commented Apr 5, 2017

Testing and coverage are all done as part of the same jest invocation, how do I give them separate targets?

@kulshekhar
Copy link
Owner

ok, I've got this

@kulshekhar
Copy link
Owner

@pelotom the fix has been published. Can you see if the latest version works for you?

pelotom added a commit to runtypes/runtypes that referenced this issue Apr 5, 2017
@pelotom
Copy link
Contributor Author

pelotom commented Apr 5, 2017

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants