Fix loading scripts with non-UTF-8 encodings. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed an issue in the in-process script loader where some scripts would fail to load with encoding errors. Instead of assuming that a script is UTF-8, a bytes string can be passed to `compile()` which will detect the encoding automatically.
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 99.53% 99.53% -0.01%
==========================================
Files 1 1
Lines 214 213 -1
==========================================
- Hits 213 212 -1
Misses 1 1
|
kvas-it
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with the in-process script loader where some scripts would fail to load with encoding errors.
Instead of assuming that a script is UTF-8, a bytes string can be passed to
compile()which will detect the encoding automatically.