This repository was archived by the owner on Apr 11, 2020. It is now read-only.
Initial implementation of Microsoft R Server adaptor #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO: While individual test cases pass, running two or more tests in test_r_server_ms.py crashes due to unexpected closing of the event loop or ZeroMQ-releated synchronization issue
* The root cause was to miss closing runner.outsock before mocking. * Refactored out _init/_shutdown methods in BaseRunner so that different event loop users can reuse them (e.g., the main program and the test fixture).
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
- Coverage 56.38% 54.89% -1.5%
=========================================
Files 16 17 +1
Lines 908 991 +83
=========================================
+ Hits 512 544 +32
- Misses 396 447 +51
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an adaptor kernel runner for Microsoft R Server API, a multi-node scalable version of R, and also improves existing BaseRunner's code structure.