Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for role-based invokes #201

Closed
wants to merge 2 commits into from

Conversation

Virviil
Copy link
Contributor

@Virviil Virviil commented Nov 24, 2017

All Bootleg mix tasks supports environment name as first parameter:

mix bootleg.ping db

except bootleg.invoke

This PR adds support for this feature:

mix bootleg.invoke my_custom_task build

Copy link
Contributor

@rjanja rjanja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Virviil thank you for opening this PR. I think it's close, but needs some changes:

  • Wording: environment and roles are very separate things. To be clear this adds support for environment-specific mix task invocations.
  • Order of parameters: in other mix bootleg tasks, one can specify the environment as the first argument e.g. mix bootleg.ping qa2. As implemented here it would be mix bootleg.invoke build qa2 which may lead to confusion.
  • We can't assume the head of the tail of the list is going to be an environment

@rjanja
Copy link
Contributor

rjanja commented Feb 18, 2018

Closing and tracking this via #221

@rjanja rjanja closed this Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants