Refactor verbosity checks #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeinhardt
force-pushed
the
drive-by-refactoring-of-ui-verbosity-checks
branch
from
885c84e to
5b536c6
Compare
|
FYI: I noticed Circle CI outputs the following over and over again in the |
|
I'll investigate the CI warning |
brienw
pushed a commit
that referenced
this pull request
Mar 1, 2018
* Refactor verbosity checks * Replace `x not in y` with `not(x in y)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a 5 min refactoring. I passed by and thought "this could be done differently"…
See if it makes sense to you 🙂