Fix config file locations and clean up test warnings #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brienw
force-pushed
the
missing_config_warning
branch
from
d1ceee6 to
93caa66
Compare
pmeinhardt
reviewed
Feb 13, 2018
config/config.exs
Outdated
| @@ -1,4 +1,4 @@ | |||
| # This file is responsible for configuring your application | |||
| # and its dependencies with the aid of the Mix.Config module. | |||
| use Mix.Config | |||
| import_config "#{Mix.env}.exs" | |||
| import_config "deploy/#{Mix.env}.exs" | |||
There was a problem hiding this comment.
Shouldn't this line just be removed? At least it seems a bit confusing to import "deploy" config into the Bootleg config 🤔
There was a problem hiding this comment.
Yes, good catch @pmeinhardt 👍
rjanja
suggested changes
Feb 13, 2018
|
Docker is giving me the business right now when i'm running the tests to verify that the cleanup of the config is kosher, hopefully resolved soon. @pmeinhardt is correct. it turns out this appears to be just cruft from the very early version of bootleg. deploy config files no longer need to be explicitly imported, as they are loaded automatically now when |
brienw
force-pushed
the
missing_config_warning
branch
from
93caa66 to
cc71db6
Compare
|
Ok, all ready @rjanja |
rjanja
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that @pmeinhardt noted after he reworked/fixed the
IOverbosity