bootleg.invoke accepts deploy env as first argument #222
Conversation
| @@ -9,14 +9,22 @@ defmodule Bootleg.MixTask do | |||
| @spec run(OptionParser.argv) :: :ok | |||
| if is_atom(unquote(task)) && unquote(task) do | |||
| def run(args) do | |||
| Config.env(List.first(args) || :production) | |||
There was a problem hiding this comment.
We already set a default production enviroment in Config.env/0 so the setting of defaults here is unnecessary I think.
There was a problem hiding this comment.
yeah, agreed. in fact, when i was running into the "environment config not set" error last week in our test suite after paul's IO refactoring it actually took me a bit to find this default that was causing it because it's so buried.
| # end | ||
| # ``` | ||
| # For more about `bootleg_phoenix` see: https://github.com/labzero/bootleg_phoenix | ||
|
|
There was a problem hiding this comment.
I think it's better to not include sample dependencies than to potentially include outdated versions by accident
| {:bootleg_phoenix, "~> 0.2"}] | ||
| end | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We don't need to include sample deps for additional packages, when doing so it just makes it harder to update versions
| {:bootleg_phoenix, "~> 0.2"}] | ||
| end | ||
| ``` | ||
|
|
| @@ -9,14 +9,22 @@ defmodule Bootleg.MixTask do | |||
| @spec run(OptionParser.argv) :: :ok | |||
| if is_atom(unquote(task)) && unquote(task) do | |||
| def run(args) do | |||
| Config.env(List.first(args) || :production) | |||
There was a problem hiding this comment.
yeah, agreed. in fact, when i was running into the "environment config not set" error last week in our test suite after paul's IO refactoring it actually took me a bit to find this default that was causing it because it's so buried.
* Invoke accepts bootleg env as first argument * Refactor and consolidate references to config paths * More refactoring * Add bootleg.invoke to README * One more refactor
Closes #221