the ability to run afterRequestScript #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetinin
reviewed
Oct 28, 2021
README.md
Outdated
| Before running an HTTP request you can run a script using cmd interface. | ||
| When the test is ran, the first step is to load fixtures and run mocks. Next, the script is executed, then the test is ran. | ||
| Before and after running an HTTP request you can run a script using cmd interface. | ||
| When the test is run, the first step is to load fixtures and run mocks. |
There was a problem hiding this comment.
Кажется When the test is ran здесь всё же правильно было и переводилось как "Когда тест запущен".
Может в целом переписать это предложение так чтобы было наглядее видно порядок выполнения. Предлагаю такой вариант
When the test is ran, operations are performed in the following order:
- Fixtures load
- Mocks setup
- BeforeScript execute
- HTTP-request sent
- АfterRequestScript execute
There was a problem hiding this comment.
У run 3я форма run. Ran это форма прошлого времени. Но я не очень англичанин, по этому не настаиваю.
Более наглядный вариант выгляди лучше. Реализую его.
fetinin
reviewed
Oct 28, 2021
README.md
Outdated
| ... | ||
| afterRequestScript: | ||
| path: './cli_scripts/cmd_recalculate.sh' | ||
| # the timeout will equal 10s |
There was a problem hiding this comment.
Ага. Копипастил невнимательно.
fetinin
approved these changes
Oct 28, 2021
nofuture17
force-pushed
the
add_after_request_script
branch
from
83332b3 to
b7140ac
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution for issue 103