(service_mock): set server address from argument #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetinin
suggested changes
Nov 21, 2021
mocks/service_mock.go
Outdated
| @@ -26,8 +26,7 @@ func NewServiceMock(serviceName string, mock *definition) *ServiceMock { | |||
| } | |||
| } | |||
|
|
|||
| func (m *ServiceMock) StartServer() error { | |||
| addr := "localhost:0" // loopback, random port | |||
| func (m *ServiceMock) StartServer(addr string) error { | |||
There was a problem hiding this comment.
Привет. Метод StartServer публичный и добавление в него нового параметра сломает обратную совместимость. Хотелось бы этого избежать.
Давай добавим отдельный метод StartServerWithAddr или StartWithAddr который будет принимать адрес.
There was a problem hiding this comment.
Да, это решение будет получше, добавил метод StartServerWithAddr
fetinin
approved these changes
Nov 23, 2021
fetinin
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Привет, хотелось бы управлять адресом поднимаемого мок сервера через аргументы, тк в моем случае тестируемый сервис находится вне сервиса откуда запускаются тесты (другой контейнер) и поэтому мне нужно предопределить адрес мок сервера при старте тестируемого сервиса