Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: introduce dropRequest strategy #195

Merged
merged 1 commit into from
Jan 17, 2023
Merged

new: introduce dropRequest strategy #195

merged 1 commit into from
Jan 17, 2023

Conversation

lansfy
Copy link
Contributor

@lansfy lansfy commented Dec 14, 2022 •
edited
Loading

for cover conditions like

	resp, err := httpClient.Do(req)
	if err != nil {
		....           # HERE
	}

@lansfy lansfy force-pushed the drop_request_strategy branch 2 times, most recently from 8541ce1 to 4dccdd1 Compare December 15, 2022 00:42
@leorush
Copy link
Contributor

leorush commented Dec 15, 2022

Would you kindly add strategy with description to schema-file? Here https://github.com/lamoda/gonkey/blob/master/gonkey.json#L190

@lansfy lansfy force-pushed the drop_request_strategy branch from 4dccdd1 to 82930f2 Compare December 15, 2022 16:22
@fetinin fetinin requested a review from vitkarpenko January 9, 2023 15:14
@fetinin fetinin added enhancement New feature or request minor release as minor labels Jan 9, 2023
@fetinin fetinin mentioned this pull request Jan 9, 2023
Open
@fetinin fetinin merged commit 87cad3e into lamoda:master Jan 17, 2023
@github-actions
Copy link

🚀 PR was released in v1.20.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitkarpenko vitkarpenko vitkarpenko approved these changes

@fetinin fetinin fetinin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request minor release as minor released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lansfy @leorush @vitkarpenko @fetinin