Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: support variables in mock definition #94

Merged
merged 1 commit into from
Sep 22, 2021
Merged

new: support variables in mock definition #94

merged 1 commit into from
Sep 22, 2021

Conversation

lansfy
Copy link
Contributor

@lansfy lansfy commented Sep 2, 2021 •
edited
Loading

Support variable's substitution in mock definition:

  mocks:
    server_mock:
      strategy: constant
      body: >
        {
          "message": "{{ $someVariable }}"
        }
      statusCode: 200

fetinin
fetinin suggested changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@fetinin fetinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Полезное дополнение, спасибо.🙏 Только просьба добавить информацию в Readme о том что можно использовать переменные в ответе моков. И добавить тест с использованием нового функционала.

@lansfy lansfy force-pushed the support_variables_in_mocks branch from 0980b20 to be16bbd Compare September 11, 2021 04:24
@lansfy lansfy requested a review from fetinin September 11, 2021 04:26
@lansfy
Copy link
Contributor Author

lansfy commented Sep 11, 2021

добавил

@fetinin fetinin added enhancement New feature or request skip-release skip release on merge to master labels Sep 22, 2021
@fetinin fetinin merged commit 76ce7fd into lamoda:master Sep 22, 2021
@github-actions
Copy link

🚀 PR was released in v1.5.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fetinin fetinin fetinin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request released skip-release skip release on merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lansfy @fetinin