Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/raae 529/simple #47

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Feat/raae 529/simple #47

merged 6 commits into from
Jan 16, 2025

Conversation

rbs333
Copy link
Collaborator

@rbs333 rbs333 commented Jan 9, 2025

  • remove secondary call for with_vectors when return_all=False
  • add functions and collapse logic for more simple flow

bsbodden
bsbodden requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other that linting failures

libs/redis/tests/unit_tests/test_vectorstores.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the mock comment :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

tylerhutcherson
tylerhutcherson reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback! nice refactor :)

@bsbodden bsbodden self-requested a review January 16, 2025 20:31
bsbodden
bsbodden approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsbodden bsbodden merged commit 7503658 into main Jan 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerhutcherson tylerhutcherson tylerhutcherson left review comments

@bsbodden bsbodden bsbodden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbs333 @bsbodden @tylerhutcherson