Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): fix bedrockRuntimeClinent to refer to endpointHost value #7797

Merged

Conversation

m-hamaro
Copy link
Contributor

@m-hamaro m-hamaro commented Mar 4, 2025

When using the Amazon Bedrock Converse API, setting the endpointHost parameter did not result in the specified endpoint being used, and it was not possible to connect to a different VPC endpoint.

To work around this issue, overriding the bedrockRuntimeClient allowed connection to the desired VPC endpoint, but this method is cumbersome.

Therefore, this pull request (PR) modifies the bedrockRuntimeClient to reference the endpointHost value when it is set.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 4, 2025
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 4, 2025 2:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Mar 4, 2025 2:08pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Mar 4, 2025
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Mar 10, 2025
@jacoblee93 jacoblee93 merged commit 89be3e1 into langchain-ai:main Mar 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants