Refactor prepare_single_task to reduce cyclomatic complexity #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split the function into helper subfunctions. - Simplify bulky nested if-statements. - Maintain original functionality.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nfcampos
reviewed
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
prepare_single_taskfunction located in./libs/langgraph/langgraph/pregel. Previously, the function had a very high cyclomatic complexity (scoring an F according to radon), making it hard to maintain and understand.To address this, I have:
These changes have improved the complexity rating from F to A. The refactor has been performed solely to improve code readability and maintainability, and the behavior of the function remains unchanged.
Please review the changes.